plaid / react-native-plaid-link-sdk

Plaid Link for React Native
MIT License
167 stars 119 forks source link

Compiler warning in AGP 8: Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported #644

Open phoenixy1 opened 3 months ago

phoenixy1 commented 3 months ago

The problem

When building the Tiny Quickstart using plaid-link-react-native 11.6.0, after upgrading from AGP 7.4.2 to AGP 8.6, I get the following warning:

> Task :react-native-plaid-link-sdk:processDebugManifest
package="com.plaid" found in source AndroidManifest.xml: /Users/ahoffer/tiny-quickstart/react_native/TinyQuickstartReactNative/node_modules/react-native-plaid-link-sdk/android/src/main/AndroidManifest.xml.
Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported, and the value is ignored.
Recommendation: remove package="com.plaid" from the source AndroidManifest.xml: /Users/ahoffer/tiny-quickstart/react_native/TinyQuickstartReactNative/node_modules/react-native-plaid-link-sdk/android/src/main/AndroidManifest.xml.

Some Googling suggests that this is a new warning in AGP 8. No errors occur, but we should probably do what the nice warning says and remove this line.