plaid / react-native-plaid-link-sdk

Plaid Link for React Native
MIT License
167 stars 119 forks source link

Timing issues resulting in PlaidLink not opening on Android after updating to 11.6 #645

Closed phoenixy1 closed 3 months ago

phoenixy1 commented 3 months ago

I am working on updating the Tiny Quickstart, and I found that it worked on Android with version 11.5.2 of the react native Link SDK, but failed when I upgraded to 11.6 because the link token was null when PlaidLink was initialized. This didn't happen on iOS, which worked fine.

PR: https://github.com/plaid/tiny-quickstart/pull/26

I'm not confident that this is actually a bug in 11.6, I think this is very likely a timing problem in the Tiny Quickstart that 11.6 exposed, but I wanted to call your attention to it in case it is a bug or in case other folks start reporting it in case we need to publicize a workaround.

phoenixy1 commented 3 months ago

PS I went back and upgraded to 11.6 again to get better logs / errors, and now it works again, which is once more pointing toward this being potentially some kind of timing problem, but is very strange.

phoenixy1 commented 3 months ago

Re-cloned the repo, installed everything from scratch, and it is happening again:

Parameter specified as non-null is null: method com.plaid.PlaidModule.create, parameter token

phoenixy1 commented 3 months ago

@dtroupe-plaid would you mind taking a look at this? It seems like it sometimes happens with 11.6 but never happens with 11.5.2. I'm not clear if this is a bug in the tiny quickstart https://github.com/plaid/tiny-quickstart/tree/main/react_native/TinyQuickstartReactNative or in the SDK itself. I believe this may also be the cause of this SO issue: https://stackoverflow.com/questions/78270015/linktoken-issue-with-react-native-tinyquickstartreactnative Please let me know if you need any additional information!