plaid / react-native-plaid-link-sdk

Plaid Link for React Native
MIT License
174 stars 120 forks source link

Layer Events Not Declared in LinkEventName Enum #693

Closed ggeigs closed 3 months ago

ggeigs commented 3 months ago

The problem

LAYER_READY and LAYER_NOT_AVAILABLE are missing from the LinkEventName enum. These event names are necessary for handling specific link events but are not available in the current enum declaration.

Environment

Plaid Link React Native 11.11.1
ReactNative Version 0.73.4
Occurs on Android yes
Android OS Version 14.0.0 (34)
Android Devices/Emulators Pixel 7a physical
Occurs on iOS yes
iOS Version 17.4
iOS Devices/Emulators iPhone 15

Steps to Reproduce

Expected Result

The LinkEventName enum should include LAYER_READY and LAYER_NOT_AVAILABLE to handle these events properly.

Screenshots

image

Logs

N/A

Code To Reproduce Issue

  usePlaidEmitter((event: LinkEvent) => {
    switch (event.eventName) {
      case LinkEventName.LAYER_READY:
        // Open Link
        break;
      case LinkEventName.LAYER_NOT_AVAILABLE:
        // Run another fallback flow
        break;
      default:
        // Other cases ignored in this use case
        break;
    }
  });
dtroupe-plaid commented 3 months ago

@ggeigs Thanks for reporting. I will get this resolved ASAP

dtroupe-plaid commented 3 months ago

@ggeigs this should be resolved in 11.11.2 I'm going to close this issue, but please let me know if you're still experiencing issues and I'll reopen.