search

plaidml / openvino

OpenVINO™ Toolkit - Deep Learning Deployment Toolkit repository
https://docs.openvinotoolkit.org/latest/index.html
Apache License 2.0
0 stars 1 forks source link

Update deformableconvolution #156

Closed DingZhangIntel closed 3 years ago

DingZhangIntel commented 3 years ago

I think there is a error about the reference implementation of deformable_convolution. The two parameters group and deformable_group is independent, and there are details about the parameter deformable_group in MXNet Suppose that the shape of input data is (1,6,5,5), the shape of filter is (2,3,3,3), the shape of the offset is (1,54,3,3), group is 2, deformable_group is 3. And an error will occur on line 256 when group_idx equals 1.

tzerrell commented 3 years ago

Is this being tested with plaidml/plaidml#1807?

DingZhangIntel commented 3 years ago

Is this being tested with plaidml/plaidml#1807?

yes.

YangleiZouIntel commented 3 years ago

This fix has merged to upstream and included in https://github.com/plaidml/openvino/pull/157

YangleiZouIntel commented 3 years ago

Changes included in upstream and the update https://github.com/plaidml/openvino/pull/159