search

plaimi / blubber-server

The blubber server
GNU Affero General Public License v3.0
2 stars 2 forks source link

Reduce code duplication due to Map/Set. #2

Open erisco opened 9 years ago

erisco commented 9 years ago

Could you provide some indication of where this code duplication is bernalex? Thanks.

ghost commented 9 years ago

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512

On 30/06/15 17:12, erisco wrote:

Could you provide some indication of where this code duplication is bernalex? Thanks. $ grep -Rl Map src src/Blubber/Server/World.hs src/Blubber/Server/ViewPort.hs

There are multiple places in here, but primarily things concerning collision detection stuff in World. It's extra messy because of the way Entity and Blub (PlayerBlub & NeutralBlub) is structured. This should be improved on as well.

Alexander alexander@plaimi.net https://secure.plaimi.net/~alexander -----BEGIN PGP SIGNATURE----- Version: GnuPG v2

iQIcBAEBCgAGBQJVkuxQAAoJENQqWdRUGk8BeaoQAJcnmpBrgOUPyvctGaH1MyI+ t86gWhnoUelwjeUcEULZlX8Mui40ksWnrC5eycHXWds0Nn8V0HTEhphK0Z3hXYFM 326+TF9XsqbFjlt/Z1r9yxdXJxVMe27xzLZmipOFyS8223sjr5oTieM4PJ94GSfx FwqvEh6OBYdpM12UYCk4Qj75uWr+nYwWYpRUYG22obZu7euYdm54v5kjmIzFa4IW qZ1rTPK3EHQ5/7eSDvyX2xl8DZ910Xv+Fn0fAPeOyNtb5DL6xEqxQeEU68Z8puBo PqkqyPdcfGF74VHRcAKP1vi5MrU/tbrWqe07QCdBIlFYNAVjfQL65bm9R/VxF5vj AnACDjac8tNyAYDrGwiP6t4ueQnqp09LFJQGjztT2bbXjCd3gsuEnYlxZr/50kG2 SHZjq21cI8CaYWX4fL+/lSbDFLdFdmXHawPyJaUPvPOaXLan07AOGRZlU4CF2SoI GnnPu9OOjn6i0hXtpoEiLP3e/px/IH/0folMJpuTCcpOTPpyA0vyH5Wy20mxZGeB 3qn3YRsq2J/6uVwgpjkYX625U1h1wi0kKNYMxPTRlEtpP8oAL08vmDBEKZHe/S/8 Xw9copNkIK4TgrpeGnXZgO4O3PSfEaxmNaYlxeisX1kaiUz9c+oBbJi8rgWUILsP 8sKi42XE21NyHf4pFF+l =pz/g -----END PGP SIGNATURE-----