search

plainblack / Lacuna-Server-Open

The open source Lacuna Server repository.
36 stars 29 forks source link

SpacePort battle logs #201

Open fireartist opened 11 years ago

fireartist commented 11 years ago

The API docs state the battle logs are cleaned out every 7 days. The battle logs on my capitol current scroll back to 26/01/2012 - almost a year.

icydee commented 11 years ago

this is something that is in the weekly cron job. I will run the weekly cron job manually to see if there is an issue with it.

On 14 January 2013 14:38, fireartist notifications@github.com wrote:

The API docs state the battle logs are cleaned out every 7 days. The battle logs on my capitol current scroll back to 26/01/2012 - almost a year.

— Reply to this email directly or view it on GitHubhttps://github.com/plainblack/Lacuna-Server-Open/issues/201.

Kind Regards Iain

icydee commented 11 years ago

this job is 'Killed' by the server so either it is a memory hog or it needs optimising I will have a quick look at it.

On 14 January 2013 15:20, Iain C Docherty me@iain-docherty.com wrote:

this is something that is in the weekly cron job. I will run the weekly cron job manually to see if there is an issue with it.

  • icydee

On 14 January 2013 14:38, fireartist notifications@github.com wrote:

The API docs state the battle logs are cleaned out every 7 days. The battle logs on my capitol current scroll back to 26/01/2012 - almost a year.

— Reply to this email directly or view it on GitHubhttps://github.com/plainblack/Lacuna-Server-Open/issues/201.

Kind Regards Iain

Kind Regards Iain

icydee commented 11 years ago

I changed the 'delete_all' (which deletes records one-by-one) to 'delete' (which deletes them via the database)

This is safe to do in this instance since there are no method modifiers on the delete method.

That works, but I will see if, now that the bulk of the messages have been deleted, it works as designed.

As a side, we perhaps need a flag/email/report (other than the log files) when a script fails to finish correctly.