Docker - Githubissues

plainblack / Lacuna-Server-Open

The open source Lacuna Server repository.

36 stars 29 forks source link

Closed icydee closed 8 years ago

icydee commented 8 years ago

Docker that works both on a Mac OS X and a linux container.

Note this version assumes Docker 1.9 (with better network support) but there are also scripts to work with Docker 1.8 (default network).

This docker container should also work with the Lacuna-Web-Client container.

icydee commented 8 years ago

I know people have not had time to test this pull request, but could it be merged anyway on the following basis?

The code is only 'additions' to the current code base which has no impact on the running code.
I (at least) have tested this on both linux and OS X and it 'works-for-me'.
If it is merged I can more easily do other changes to the main code base

Yes there are a few small issues with the code but again I can more easily fix these if the code is merged first.

Ta...

lemming552 commented 8 years ago

Merged, but I had to rebase to continue the --ff-only.

icydee commented 8 years ago

thank you Norway, I had been doing rebases as develop was being updated. If you ever need me to resubmit the pull request I can do the rebase.