possible s3file upgrades

plainblack / ving

An opinionated web services starter for Nuxt3 that provides REST and per-field privileges out of the box.

https://plainblack.github.io/ving/

58 stars 7 forks source link

possible s3file upgrades #120

Closed rizen closed 2 months ago

rizen commented 2 months ago

maybe detect image properties with https://unjs.io/packages/image-meta
switch from jimp to sharp https://sharp.pixelplumbing.com

rizen commented 2 months ago

image-meta supports very few file formats compared to image-size

rizen commented 2 months ago

sharp is faster than jimp, but jimp is working fine, so I'm not seeing a compelling reason to switch presently

pi0 commented 2 months ago

let me know what format you find missing.

btw just you know i still have access to this repo but not see all notifs.

pi0 commented 2 months ago

also check-out ipx.unjs.io for a better sharp wrapper. it had been under production load for >6 years.

rizen commented 2 months ago

let me know what format you find missing.

image-size has all these file formats: https://www.npmjs.com/package/image-size

But honestly, you would need to have more than what it has in order to make it a compelling reason to switch. I'm certainly not trying to create more work for you, as I know how busy you are already.

btw just you know i still have access to this repo but not see all notifs.

I think you get the notifications because you have starred the repo.