search

plainheart / echarts-extension-gmap

🌎 A Google Map (https://www.google.com/maps) extension for Apache ECharts (https://github.com/apache/echarts)
https://github.com/plainheart/echarts-extension-gmap
MIT License
48 stars 8 forks source link

Can't use option { gestureHandling: "cooperative" } with google maps #19

Closed Anton-Plagemann closed 1 month ago

Anton-Plagemann commented 1 month ago

I tried to use these options:

{
  gmap: {
      gestureHandling: "cooperative",
    }
}

(see here on more information on the option gestureHandling)

But that doesn't work, because its getting overwritten with the value auto on each render (so I also can't set it afterwards using chart.getModel().getComponent("gmap").getGoogleMap().setOptions({ gestureHandling: "cooperative" })) 😟

https://github.com/plainheart/echarts-extension-gmap/blob/4d3c75491873f0c3acf4a5b14cb97edd0cca76b3/src/GMapView.js#L74-L76

Could we change that? I would be happy to submit a PR 😊

plainheart commented 1 month ago

I think it makes sense. Feel free to open a PR fix it. :)