search

plainheart / echarts-extension-gmap

🌎 A Google Map (https://www.google.com/maps) extension for Apache ECharts (https://github.com/apache/echarts)
https://github.com/plainheart/echarts-extension-gmap
MIT License
48 stars 8 forks source link

Prevent override of gmap gestureHandling setting #20

Closed antonplagemann closed 1 month ago

antonplagemann commented 1 month ago

Fixes #19

This pr adds the smalles possible change to fix #19, allowing to use the google maps gestureHandling setting in the extension configuration object. I've tested the proposed changes with my application.

It also shouldn't break existing behaviour as shown in the following table (3 behaviour changes marked bold):

roam gestureHandling old behaviour new behaviour
true (default) "cooperative" gestureHandling set to "auto" gestureHandling set to "cooperative"
true (default) "greedy" gestureHandling set to "auto" gestureHandling set to "greedy"
true (default) "none" gestureHandling set to "auto" gestureHandling set to "none"
true (default) "auto" gestureHandling set to "auto" gestureHandling set to "auto"
true (default) undefined gestureHandling set to "auto" gestureHandling set to "auto"
false "cooperative" gestureHandling set to "none" gestureHandling set to "none"
false "greedy" gestureHandling set to "none" gestureHandling set to "none"
false "none" gestureHandling set to "none" gestureHandling set to "none"
false "auto" gestureHandling set to "none" gestureHandling set to "none"
false undefined gestureHandling set to "none" gestureHandling set to "none"

Happy to receive your review @plainheart 😊 And btw, thanks for the great extension! 🙌

plainheart commented 1 month ago

Thank you! I will release a new version for this change later.