search

plamere / OrganizeYourMusic

Organize your saved music on Spotify
242 stars 40 forks source link

No action on clicking "organize your music" #4

Open cdpb opened 5 years ago

cdpb commented 5 years ago

Tested only with mobile device on Brave Browser and Firefox Mobile. By clicking the button "organize your music" there is no action at all, no forward, no credentials, no reload.

ghost commented 5 years ago

I noticed a typo in line 2035, programs never like typo's. don't know if this will fix the issue but my guess is that the program crashes right there and won't be able to give any output. elif must be elseif? LINE 2035: } elif (fields.length == 5) { if (fields[0] != 'spotify' || fields[3] != 'playlist') { return false; } }

lursyy commented 5 years ago

@ghost: elif is the valid python syntax for "else if": https://www.tutorialspoint.com/python/python_if_else.htm

ericcastro commented 4 years ago

@lb28 except this is javascript, captain. elif isn't valid javascript. wondering if @plamere will ever fix such dumb typo?

chdprimary commented 4 years ago

@ericcastro See #5 — the non-broken version is hosted at http://organizeyourmusic.playlistmachinery.com/index.html

jtagcat commented 3 years ago

Tested only with mobile device on Brave Browser and Firefox Mobile. By clicking the button "organize your music" there is no action at all, no forward, no credentials, no reload.

Both of them block 3rd party stuffs. See https://github.com/plamere/OrganizeYourMusic/issues/11#issuecomment-810461423