plamish / xcomfort

Eaton xComfort SHC integration for Home Assistant
18 stars 5 forks source link

How to add more zones? #30

Open jeroenhubgit opened 1 year ago

jeroenhubgit commented 1 year ago

I just tried your wonderfull integration :)!

I have 20 zones in my xComfort SHC. How can i add them all? It seems that now it's only possible to add 5 zones.

image

BirgerKo commented 1 year ago

Hi, I made one zone with all items in and used those in Home Assistant. Why do you need to import the 20 zones?

tor. 1. des. 2022 kl. 22:19 skrev jeroenhubgit @.***>:

I just tried your wonderfull integration :)!

I have 20 zones in my xComfort SHC. How can i add them all? It seems that now it's only possible to add 5 zones.

[image: image] https://user-images.githubusercontent.com/88284339/205161138-3555e9d4-222d-4ad3-86fb-599175e5dfe8.png

— Reply to this email directly, view it on GitHub https://github.com/plamish/xcomfort/issues/30, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISD6RXR35J6ZOCWVTMJJT3WLEI57ANCNFSM6AAAAAASRHIT74 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jeroenhubgit commented 1 year ago

Hi BirgerKo,

Thx for the response :). Lights etc. I could put in one zone, although that's also not perfect for me.

Mainly it won't work, since I have many controlled heating zones which are needed due to multiple actuators for floor heating and radiators. Without more zones they can't be controlled independently with different startup times and master/slave settings. Also I use the zones for macro's that are used inside xComfort. I tried to have one zone in the past, but that gave me a lot of problems in my setup which I eventually had changed due to technical advice of EATON.

Is it possible to add more heating zones?

I see there is code written in the 'climate.py' and also in 'config_flow.py' and 'en.json'. Can I just add more zones there, save it and copy it manual in HA? Or that won't work?

image

plamish commented 1 year ago

Hey jeroenhubgit, Yes, you would need to add more zones in climate.py like you showed on the picture and also in config_flow.py. Nothing complicated. Good luck

jeroenhubgit commented 1 year ago

Hi plamish,

Thx for the confirmation. The code looks very neat and compact btw!

I'm learning some python for a while and i'm starting to understand more and more. So I just tried and it seems to work. Tomorrow we're going to test it on the network.

Btw, the first input 'zone'. Is that one used for other devices than heating? And also, is the 'RM" description for heating zone 0 just a typo and also a radiator like the other zones, or is that input for sth else?

image

plamish commented 1 year ago

Support for heating zones is really primitive :-)

"RM" indicates the heating zone is controlled by Room Manager. The first heating zone is coded to be controlled by Room Manager and other zones by radiator valves.

There is slight difference on how SHC builds device name for RM based thermostat vs. radiator valve. In climate.py line 164 you can see RM based thermostat has _u12 at the end and radiator valve _u0.

In climate.py line 55 you can see True at the end, where other climate zones have False. That's exactly how you define if zone is RM based.

I hope that helps.