search

plan-your-vote / plan-your-vote-cda

Plan Your Vote - Content Delivery Application
https://plan-your-vote.amyhong0502.now.sh/
3 stars 5 forks source link

No filter and no search #78

Closed medhatelmasry closed 4 years ago

medhatelmasry commented 5 years ago

Filter candidates by races should be a dropdown list

medhatelmasry commented 4 years ago

As part of assignment 2, Peter Kim implemented filtering of candidates. This is a dropdown list that displays races.

We need to get a list of races from the backend rather than hard-coding them on the front end.

medhatelmasry commented 4 years ago

Filter by vice-president causes an error.

pkim92 commented 4 years ago

Pull request 19 on Mohammad's fork (https://github.com/msalamat/plan-your-vote-cda/pull/19) created to fix and grab option values dynamically. The reason why "vice-president" option threw an error during the demo was that this was actually not a valid option within the Candidate component's race state. (As the seed data was genericized)

medhatelmasry commented 4 years ago

THe only item that is added to data coming from backend regarding races is "All". This issue is resolved.