plan2net / webp

Create a WebP copy for images (TYPO3 CMS)
GNU General Public License v3.0
60 stars 34 forks source link

Not all pictures get converted to webp (Case Sensitive!) #18

Closed the-hotmann closed 5 years ago

the-hotmann commented 5 years ago

All images with the ending "jpg" gets converted to webp No images with the ending "JPG" gets converted to webp!

I THINK "Jpg", "JPg", "JPG", "jPG", "jpG", "JpG" and "jPg" will be ignored. Same at png.

nur jpg aber keine JPG

I would recommend implementing this: LINK to make RegEx ignoringing case-sensitive.

Also (png|jpg|jpeg) could get shorten down to (png|jpe?g) but this one is just cosmetic

wazum commented 5 years ago

You can do whatever you want in your rewrite rules (the extension has nothing to do with that).

The webp files are generated for alle file extensions you mentioned. https://github.com/plan2net/webp/blob/master/Classes/Processing/Webp.php#L142

the-hotmann commented 5 years ago

I know, the second part was just for having shorter RegEx.

But how can I (re)start the convertion process? NONE of the Files with "JPG" has been converted, but nearly all with "jpg" how do you explain that? So for me not all Images has been converted

the-hotmann commented 5 years ago

Just tested it again.

Tested with Pic which does not get processed (pic still in /fileadmin/user_upload/) Uploaded 35 HR Images (half JPG half jpg)

All Images get included with full Link to source and once processed. All pics in processed are webp (and jpg after being processed) All JPG pics in user_upload are delivered as jpg (webp not even generated!) All jpg pics in user_upload are delivered as webp.

See Screenshot: JPG = no webp (All this picutres are located in the same folder!)

Have done this from an anonym Tab with cach flushed in Chrome. Also I checked my htaccess and the other configs. If there would be any error it would not work at all but its just not working at Files with JPG (which gets included directly without processing)

I dont think this Issue is invalid

the-hotmann commented 5 years ago

Another thing I noticed:

All my JPG Files are all bigger then 1,2 MB (up to 3,5 MB) All my jpg Files are all smaller then 800kb

Is there maybe a limitation of PHP, Ressoureces, Times which just applys to the JPG Files but not because they are JPG but because they are much more bigger (about 6000x4000 px)?

Noticed there is this Error in my Log: (70007)The timeout specified has expired: AH01075: Error dispatching request to : (polling) Maybe its related to this maybe not.

Also all of my Images are "responsive Images" wich 4 lower resolutions. So for all this big pictures (which itself also have to be converted to webp, also 4 smaller editions of it also have to be converted to webp. Could this also be the problem?

Will debug this a bit and report back

EDIT

Cant solve it. my config at this Test is btw 75% quality and lossy. JPG does not get converted

the-hotmann commented 4 years ago

Any news on this? Why are images ending with "JPG" not getting converted, but if they end with "jpg" they do?

Cant the Extension handle JPG Files but jpg? The only difference is the file extension is wrote uppercase.

Why is convertion not getting triggered for the uppercase ones?