plan2net / webp

Create a WebP copy for images (TYPO3 CMS)
GNU General Public License v3.0
60 stars 34 forks source link

Why is 85% quality fallback when no constant is given? #4

Closed the-hotmann closed 5 years ago

the-hotmann commented 5 years ago

Constant default is: (95%) Quality https://github.com/plan2net/webp/blob/a8f003610905012fa869252c976d6e6d3e8ac014/ext_conf_template.txt#L2

But when Constant is empty etc it uses Fallback to 85% Quality like this would be the standard, but standardquality is 95% not 85% https://github.com/plan2net/webp/blob/a8f003610905012fa869252c976d6e6d3e8ac014/Classes/Service/Image/Webp.php#L69-L73

README.md also shows 95% Quality as standard, not 85%: https://github.com/plan2net/webp/blame/master/README.md#L39-L41

Is this a Typo or just a fallback to 85% in ImageMagick?

wazum commented 5 years ago

Thanks for the hint, I just overlooked that. Fixed in version 1.1.0 (available through packagist via composer)