search

plan2net / webp

Create a WebP copy for images (TYPO3 CMS)
GNU General Public License v3.0
60 stars 33 forks source link

[BUGFIX] Handle hardened GFX processor_stripColorProfileCommand #93

Closed eliashaeussler closed 5 months ago

eliashaeussler commented 6 months ago

With TYPO3-CORE-SA-2024-002, the previously used configuration option $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_stripColorProfileCommand'] was replaced by a new configuration option $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_stripColorProfileParameters'] which provides an array instead of a string. This PR adapt the codebase in MagickConverter to use the new configuration option, but stays compatible with legacy configurations.

Resolves: #92

wazum commented 6 months ago

@eliashaeussler Thanks for the pull request, looks fine. One question, though: Should parseStripColorProfileCommand(): mixed not always return a string (I really don't like the mixed type hint)?

eliashaeussler commented 6 months ago

Should parseStripColorProfileCommand(): mixed not always return a string (I really don't like the mixed type hint)?

You're right, I changed it to a string return, see db02355.

thommyhh commented 5 months ago

@wazum Any chance, this gets merged soon? It's kind of deal-breaker.