Encountered nulls in route_location.crs_code field

planarnetwork / dtd2mysql

MySQL / MariaDB import for DTD feeds (fares, timetable and routeing)

30 stars 10 forks source link

Encountered nulls in route_location.crs_code field #6

Closed eoghanmurray closed 7 years ago

eoghanmurray commented 7 years ago

Line 625 of RJFAF499.RTE: RL009892711201670 M510 E

Hopefully there aren't any knock on effects of having this column nullable. Should these entries just be rejected instead? (location excluded is 'Dun Laoighaire' [Ireland] for routecode 00980 'HLYHD IRISHF CIV'; presumably this is an alternate destination that they want to disallow when using Rail+Sail)

linusnorton commented 7 years ago

I believe I may have beaten you to the punch - https://github.com/open-track/dtd2mysql/commit/3121c400712907f853bbad9ef5452e898cd3ba18

Although I would expect github to show a conflict

eoghanmurray commented 7 years ago

Great!