trips.txt only shows one destination instead of two for some routes

planarnetwork / transxchange2gtfs

tool to convert transxchange data into a GTFS feed

30 stars 17 forks source link

trips.txt only shows one destination instead of two for some routes #18

Closed markerpen closed 5 years ago

markerpen commented 5 years ago

Hi there,

I've noticed on some routes (LBAO022 for Edinburgh Buses service 22, for example) the inbound destination is the same as the outbound destination, even though it should be different (the outbound destination is 'Gyle Centre' in the TransXChange file, but is 'Ocean Terminal' in the GTFS file).

Any possibility of fixing this? You've done a great job so far in creating a reliable GTFS feed.

linusnorton commented 5 years ago

Hi @markerpen I can take a look - do you have a TransXchange file I can use to replicate the problem?

markerpen commented 5 years ago

hi @linusnorton - I've attached the relevant NaPTAN file - you'll see in the Services->Service->StandardService node (line 128232) the Origin ('Gyle Centre') isn't used for inbound journeys, instead the Destination (which should be used on outbound journeys) is used instead. SVRLBAO022.xml.zip

linusnorton commented 5 years ago

@markerpen I've just pushed a fix and released version 1.4.1 which should fix this issue.

I found that the trip headsign was not being reversed for inbound journeys but trip stop times were correct.

markerpen commented 5 years ago

Great job - thanks for all your hard work!