build of packaged (2.24.0) version fails

planck-repl / planck

Stand-alone ClojureScript REPL

https://planck-repl.org

Eclipse Public License 1.0

1.03k stars 67 forks source link

build of packaged (2.24.0) version fails #1021

Open rpodgorny opened 4 years ago

rpodgorny commented 4 years ago

when i clone the git repo and run script/build everything builds fine.

but when i download the 2.24.0.tar.gz package and try to build that, it fails with:

Creating an optimized build, using build cache to speed up build.
Specifying --fast skips optimizations and takes less than two minutes.
### Building planck-cljs
Syntax error (IllegalArgumentException) compiling at (script/build.clj:30:1).
/tmp/pkgbuilds/planck/src/planck-2.23.0/planck-cljs/out/goog/i18n/datetimesymbols.js is not a relative path

(running this from /home/user/tmp/pkgbuilds/planck) ...so it seems like the /home/user part gets cut off and that causes the failure.

mfikes commented 4 years ago

@rpodgorny Hrm. That's odd, and I can't repro.

I'm wondering how planck-2.23.0 appears in the path in your issue description (while the downloaded package is for 2.24.0.tar.gz)

rpodgorny commented 4 years ago

ahh, sorry about that. i also tried with 2.23 just to be sure it's not a problem of specific version but rather a problem of (any?) "packaged" version... ...the output for 2.24 is just the same.

mfikes commented 4 years ago

Cool. Are you on Linux? (I tried reproing on macOS).

Happy to take a patch if you see the issue. Otherwise need to sort out how to actually repro. :)

rpodgorny commented 4 years ago

yes, i'm on arch linux.

for me, it's just:

wget https://github.com/planck-repl/planck/archive/2.24.0.tar.gz
tar xvf 2.24.0.tar.gz
cd planck-2.24.0
script/build

i'll try to investigate further...

rpodgorny commented 4 years ago

so, after copying planck-cljs/deps.edn from git version the the unpacked, everything works... ...the diff is:

--- planck-2.24.0/planck-cljs/deps.edn  2019-07-26 03:23:11.000000000 +0200
+++ planck/planck-cljs/deps.edn 2019-11-09 17:57:54.256620034 +0100
@@ -1,6 +1,8 @@
 {:deps {org.clojure/clojurescript {:mvn/version "1.10.520"}
+        org.clojure/google-closure-library {:mvn/version "0.0-20190213-2033d5d9"}
         org.clojure/test.check {:mvn/version "0.10.0-alpha4"}
         com.cognitect/transit-cljs {:mvn/version "0.8.256"}
+        com.cognitect/transit-js {:mvn/version "0.8.861"}
         fipp {:mvn/version "0.6.18"}
         malabarba/lazy-map {:mvn/version "1.3"}
         cljsjs/long {:mvn/version "3.0.3-1"}}}

i still wonder how come it works for you... ;-)

rpodgorny commented 4 years ago

fyi, this workaround also works:

sed 's_lib/closurelib/closure/goog' -i planck-cljs/script/build.clj