planck-repl / planck

Stand-alone ClojureScript REPL
https://planck-repl.org
Eclipse Public License 1.0
1.03k stars 68 forks source link

ci: adopt JDK is deprecated #1097

Closed lread closed 2 years ago

lread commented 2 years ago

Currently

Planck's GitHub Actions config selects adopt JDK8. https://github.com/planck-repl/planck/blob/e9dfcada4b92d72210c568ef8cf23967d06bd043/.github/workflows/build_test_planck.yml#L31-L34

But...

This distribution has been deprecated:

NOTE: Adopt OpenJDK got moved to Eclipse Temurin and won't be updated anymore. It is highly recommended to migrate workflows from adopt to temurin to keep receiving software and security updates. See more details in the Good-bye AdoptOpenJDK post.

So...

Am happy to planck you to temurin JDK8. I'd probably do this for the macos build too, just to be explicit.

Next Actions

Happy to do the PR.

Could also include other minor updates to ci workflow config (ex. setup-clojure now supports installing the cli on macos).