search

planemo-autoupdate / autoupdate

4 stars 6 forks source link

Improve autoupdate round 2 #37

Closed lldelisle closed 2 months ago

lldelisle commented 2 months ago

Looking at the logs there are at least 2 things to fix:

lldelisle commented 2 months ago

@nsoranzo I added this head -n 1 because you can have multiple closed PR from the same branch, see https://github.com/bgruening/galaxytools/pull/1353 and https://github.com/bgruening/galaxytools/pull/1350. This is what caused the CI to fail for bgruening galaxytools repo: https://github.com/planemo-autoupdate/autoupdate/actions/runs/10995709180/job/30537933271#step:10:1069

But probably the head -n 1 is only useful for closed PR.

nsoranzo commented 2 months ago

Yes, I think you missed my suggestion to add | head -n 1 at line 127.

lldelisle commented 2 months ago

Indeed, I just fixed this.

lldelisle commented 2 months ago

Sorry...

nsoranzo commented 2 months ago

Thanks @lldelisle !

lldelisle commented 2 months ago

This will probably need a round 3 but thanks @nsoranzo for the review. I feel like we are moving forward.