planemo-autoupdate / autoupdate

4 stars 6 forks source link

Improve autoupdate round 3 #38

Closed lldelisle closed 2 months ago

lldelisle commented 2 months ago

I found 2 bugs. First one is easy, if we do the | head -n 1 then even if there is no output it will be true. I proposed a fix which is to do the head -n 1 after. The second one is relatively hard. My strategy for workflows was that if the file CHANGELOG.md does not change, we do not push new commits but if it changes we force push. I forgot that the CHANGELOG.md contains the date... So if you run autoupdate on 2 different days it will consider changes while it is just the date which changed. I propose a fix which is to check if it is a workflow if there is a single line changing.

lldelisle commented 2 months ago

As I am writing a PR I incorporated 2 other changes:

lldelisle commented 2 months ago

Two other improvements:

lldelisle commented 2 months ago

Let's hope it will not fill the inbox of people this time...