planet-nine-app / sessionless

A repo for the sessionless protocol
https://sessionless.org
MIT License
38 stars 10 forks source link

Add missing header files for arm-zephyr-eabi toolchain #46

Closed sharpe-developer closed 3 months ago

sharpe-developer commented 3 months ago

The zephyr toolchain requires explicit includes, This is needed for MAGIC project (or any Zephyr hardware targeted projects).

sharpe-developer commented 3 months ago

Will this disrupt any other system? Like should we split this implementation, or is it fine to leave it as the solitary implementation?

It should be fine as is. This was just a side effect of using a straight Linux GCC compiler for initial testing. The Linux GCC compiler included many standard libs already so it built without errors even though I was missing the explicit include files for the standard library stuff I was using. When building on the Zephyr toolchain it was more strict and exposed my lack of explicit include files. Adding these includes now should make it more robust 🥂 😜 for all future users of this library.