Closed tkiapril closed 1 year ago
This PR has 659
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
The reason why it has prisma/prisma is that prisma expects the schema to be at prisma/schema.prisma by default, and it expects the migrations to be inside prisma/migrations, so if we were to support db migration with multiple dbs (sqlite/postgresql) without having to switch provider every single time creating migrations, it might be better off to generate modified prisma schema files inside nested directories (prisma/prisma-sqlite and prisma/prisma-postgresql?). I agree the name of shim-inner is weird, but the thing is that shim.ts currently also does the job of combining prisma types from index.d.ts without implementation with the Prisma namespace with implementation, so I'm a bit concerned if it's okay to rename shim.ts to mod.ts and shim-inner.ts to shim.ts (as mod.ts itself works as a second-layer shim.)
I've been thinking about good convention to rename shim-inner.ts, but I couldn't in a while, so I'll merge and keep thinking about it, and if someone or I get a good Idea make a new PR to rename it.
dev.ts
are located at root..ts
files containing constant values are put toconstant/
.devTools
contains standalone programs useful in development.messages
contains codes related to messaging between components.prisma
encapsules prisma related code (shim, wrapper, etc.).sample
contains sample contract and related stuff.scripts
contains standalone management scripts.utils
contains general utility code.web
contains web dashboard code.closes #24