Closed moreal closed 9 months ago
@longfin I pushed more commits to pass lint CI check and makes Docker image build success[^1].
[^1]: Docker build is failing, https://github.com/planetarium/NineChronicles.Bridge/actions/runs/6902303428/job/18778737221
This PR has 50
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
It resolves #20
It makes bridge able to use KMS account. For the backward-compatibility, if there is no other configuration, it uses
NC_UPSTREAM_PRIVATE_KEY
andNC_DOWNSTREAM_PRIVATE_KEY
. To useKMS
feature, setNC_UPSTREAM_ACCOUNT_TYPE=KMS
and setNC_UPSTREAM__KMS__KEY_ID
andNC_UPSTREAM__KMS__PUBLIC_KEY
[^1].You can get public key and address easily by the below script.
[^1]: uncompressed format