planetarium / NineChronicles.Headless

A headless node of NineChronicles game network, powered by Libplanet.
https://planetarium.github.io/NineChronicles.Headless/
GNU Affero General Public License v3.0
35 stars 37 forks source link

Initial settings for dpos headless test #2442

Open limebell opened 4 months ago

limebell commented 4 months ago

This PR references lib9c of version https://github.com/planetarium/lib9c/pull/2506

Here are sample config.json file

{
    "$schema": "./config.schema.json",
    "data": {
        "tablePath": "./Lib9c/Lib9c/TableCSV"
    },
    "currency": {
        "initialMinter": "",
        "initialCurrencyDeposit": [
            {
                "address": "",
                "amount": 100000,
                "start": 0,
                "end": 0
            }
        ]
    },
    "admin": {
        "activate": false,
        "address": "",
        "validUntil": 100000
    },
    "initialValidatorSet": [
        {
            "publicKey": "033c6c9c14ba5d1b53badb345da5c6b203a5aae5ff69c7f6ae35f1b9c5fb8ba0c5",
            "power": 1
        }
    ],
    "initialMeadConfigs": [
        {
            "address": "0x7240303aa8Ce9c88a776F4a703D0A504f2004CBE",
            "amount": "10000000"
        }
    ],
    "initialNCGConfigs": [
        {
            "address": "0x7240303aa8Ce9c88a776F4a703D0A504f2004CBE",
            "amount": 100
        },
        {
            "address": "0x75bEc0C5f78178917CB94154D9B637feAfB9294b",
            "amount": 100
        },
        {
            "address": "0x2d4c69583Bf760E4EE5db3eBC7495C1CD87a7A29",
            "amount": 100
        },
        {
            "address": "0x0459d95d037EbF0F1626eEcCc8441a55E4007AA2",
            "amount": 100
        }
    ]
}
pull-request-quantifier-deprecated[bot] commented 4 months ago

This PR has 167 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

``` Label : Medium Size : +126 -41 Percentile : 53.4% Total files changed: 15 Change summary by file extension: .cs : +125 -40 Lib9c : +1 -1 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detected. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.


Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.