search

planetarium / NineChronicles

Unity client application for Nine Chronicles, a fully decentralized idle RPG powered by the community.
https://nine-chronicles.com/
GNU Affero General Public License v3.0
359 stars 149 forks source link

Stage시트 정리 #5307

Open eugene-doobu opened 2 months ago

eugene-doobu commented 2 months ago

스테이지 시트의 불필요한 값을 제거하고 정리합니다. lib9c 수정 대응을 위한 이슈입니다

확인대상

관련이슈

https://github.com/planetarium/NineChronicles/pull/5283

Stage시트에서 사운드를 어떻게 처리할건지에 따라, 해당 pr에서 추가한 스테이지 bgm 키들을 제거할지 결정

eugene-doobu commented 1 month ago

https://planetariumhq.slack.com/archives/C01G0G7B073/p1718963534751829

eugene-doobu commented 1 month ago

https://planetariumhq.slack.com/archives/C01D7N32V55/p1717747814988199

eugene-doobu commented 1 month ago

HackAndSlash 211 line

eugene-doobu commented 1 month ago 
            var sw = new System.Diagnostics.Stopwatch();
            sw.Start();
            var sheetTypes = new [] {typeof(StageSheet)};
            for (int i = 0; i < 3000; i++)
            {
                Dictionary<Type, (Address, ISheet)> sheets = states.GetSheets(sheetTypes);
                var test = sheets.GetSheet<StageSheet>();
            }
            sw.Stop();
            Log.Debug("CombinationConsumable GetSheet 1000 times: {Elapsed}", sw.Elapsed);

테스트코드

eugene-doobu commented 1 month ago

현재기준 9.5672186999999997 9.1481154999999994 71.9KB (73,677 바이트)