Apply code reviews and improve performances

planetarium / lib9c

Lib9c is a library that contains key implementations of Nine Chronicles, a decentralized RPG developed with Libplanet. Lib9c includes Nine Chronicle's key features like in-game decisions and data models, which can be used to implement game core capabilities.

https://nine-chronicles.com/

GNU General Public License v3.0

22 stars 39 forks source link

Apply code reviews and improve performances #2641

Closed U-lis closed 1 week ago

U-lis commented 1 week ago

Use Weighted selector to pick reward
Add missing conditions
- Cannot explore(challenge) after reached max floor before unlock
- Transfer remaining bounty once
Optimization
- Use avatar state to handle avatar and inventory, not call inventory state once again
- Validate signer-avatar using AddressesHex, not calling state

U-lis commented 1 week ago

@ipdae idun setting 을 위해 merge 합니다. 리뷰 부탁드립니다.