search

planetarium / lib9c

Lib9c is a library that contains key implementations of Nine Chronicles, a decentralized RPG developed with Libplanet. Lib9c includes Nine Chronicle's key features like in-game decisions and data models, which can be used to implement game core capabilities.
https://lib9c.nine-chronicles.dev/
GNU General Public License v3.0
27 stars 48 forks source link

Remove `AvatarState.combinationSlotAddresses` #2763

Open eugene-doobu opened 2 months ago

eugene-doobu commented 2 months ago

allCombinationSlotState로 마이그레이션 된 시점부터 필요없어진 CombinationSlotAddress 제거

참고

https://github.com/planetarium/lib9c/pull/2751

eugene-doobu commented 1 month ago

AvatarState.combinationSlotAddresses

moreal commented 1 month ago

Hello @eugene-doobu. You may think that this issue can be resolved by removing AvatarState.combinationSlotAddresses field, right? When I'm looking around this issue, I looked the field is de/serialized from/to Bencodex format.

https://github.com/planetarium/lib9c/blob/e976cfeabbe41cc64877ac4e2d5f18797960bf20/Lib9c/Model/State/AvatarState.cs#L1294-L1297

After removing the field, what value should fill the place where used by combinationSlotAddresses? Bencodex.Types.Null.Value?

eugene-doobu commented 1 month ago

@moreal The reason for not touching this issue was that the field was needed de/serialized, After erasing the above value, Maybe I should fill it with Bencodex.Types.Null.Value.