search

planetarium / libplanet-explorer-frontend

Libplanet Explorer Frontend
https://explorer.libplanet.io/
MIT License
16 stars 27 forks source link

Run faster in Docker #20

Closed earlbread closed 4 years ago

earlbread commented 5 years ago

We can run this project as docker thanks to #18. However, it takes time to run because the image runs npm run dev every time. It would be better to build the static files when making the docker image and serve it when running the image.

kmjayadeep commented 4 years ago

Can I take this up?

dahlia commented 4 years ago

@kmjayadeep Of course, here you go! :+1:

kmjayadeep commented 4 years ago

Thanks! Expect a PR soon :)

kmjayadeep commented 4 years ago

I'm writing a docker-compose file too. What should I give as the name of the image? Are you planning to host the container in dockerhub?

dahlia commented 4 years ago

Oh, yes, it would be great if we can push images to Docker Hub!  The image name should be same to this GitHub repository name. On Oct 1, 2019 1:11 AM +0900, Jayadeep K M notifications@github.com, wrote:

I'm writing a docker-compose file too. What should I give as the name of the image? Are you planning to host the container in dockerhub? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

kmjayadeep commented 4 years ago

Okay, i will name it as planetarium/libplanet-explorer-frontend

dahlia commented 4 years ago

33 fixed this.