search

planetarium / libplanet-explorer

Libplanet Explorer now belongs to the Libplanet monorepo. This repository remains read-only as historical archive.
https://github.com/planetarium/libplanet/tree/main/Libplanet.Explorer
10 stars 20 forks source link

Mysqlstore #146

Open area363 opened 3 years ago

area363 commented 3 years ago

This is a draft PR for Libplanet.MySQLStore.

area363 commented 3 years ago

Error: MySQLKeyValueStore.cs(18,18): error S101: Rename class 'MySQLKeyValueStore' to match pascal case naming rules, consider using 'MySqlKeyValueStore'. [/home/runner/work/libplanet-explorer/libplanet-explorer/Libplanet.MySQLStore/Libplanet.MySQLStore.csproj] Should I make QL lowercase?

riemannulus commented 3 years ago

https://github.com/planetarium/libplanet-explorer/pull/146/checks?check_run_id=1667453906#step:4:34 CI was failed. Is only failed at CI or your local too?

moreal commented 3 years ago

Error: MySQLKeyValueStore.cs(18,18): error S101: Rename class 'MySQLKeyValueStore' to match pascal case naming rules, consider using 'MySqlKeyValueStore'. [/home/runner/work/libplanet-explorer/libplanet-explorer/Libplanet.MySQLStore/Libplanet.MySQLStore.csproj]

Should I make QL lowercase?

IMO it should be lowercase by following the analyzer. Though, I used SQL at MySQLRichStore because there wasn't SonarAnalyzer. It should be fixed also.

dahlia commented 3 years ago

As Libplanet Explorer became placed in the Libplanet monorepo (see also: planetarium/libplanet#1244), this pull request should be sent to the Libplanet monorepo instead.