search

planetarium / libplanet-explorer

Libplanet Explorer now belongs to the Libplanet monorepo. This repository remains read-only as historical archive.
https://github.com/planetarium/libplanet/tree/main/Libplanet.Explorer
10 stars 20 forks source link

Support Libplanet.RocksDB implementation #98

Closed moreal closed 4 years ago

moreal commented 4 years ago

It resolves a part of #97 by supporting Libplanet.RocksDB implementation.

Sadly, there is a problem that the execution with dotnet run ~ doesn't work, but fortunately, it works with dotnet Libplanet.Explorer.Explorer.dll ~. I wonder it's a problem only in my environment. I left also the log.

Therefore I opened this pull request as a draft. If the problem was resolved or it was okay to not work with this, I will turn its state to Ready for review.

moreal commented 4 years ago

I'm not sure the exact cause, but it seems to be a problem with Planetarium.RocksDBSharp. We can avoid this problem by raising the TargetFramework of Libplanet.Explorer.Executable to netcoreapp3.1.

I raised TargetFramework to netcoreapp3.1 in e37ffb2d3c06a166f0d53c9066563a8b164e7aae, but it failed to build on GitHub Actions on pull request workflow. because it uses .NET Core SDK 2.2.103 there. So I will open new pull-request to raise the version and will request review again after it merged.

PS. the commit, e37ffb2d3c06a166f0d53c9066563a8b164e7aae, has gone because it was resolved in #99 instead.

moreal commented 4 years ago

There seems to be a conflict.

@longfin I resolved the conflict 😀