Typo in `Libplanet.Tx.Transaction<T>.Create()` method's docs

planetarium / libplanet

Blockchain in C#/.NET for on-chain, decentralized gaming

https://docs.libplanet.io/

GNU Lesser General Public License v2.1

510 stars 144 forks source link

Closed moreal closed 3 years ago

moreal commented 3 years ago

There is a sentence to describe when the exception will be thrown, Thrown when null is passed to privateKey or or actions.. To me, the continuous two ors look like a typo. https://github.com/planetarium/libplanet/blob/d3ea9492145db52d4b0295b2d87b333b2b2c51a2/Libplanet/Tx/Transaction.cs#L398-L399

P.S. If it is correct grammer which I don't know, you can close this issue anytime.

dineshkumar12004 commented 3 years ago

Can i work on this issue @moreal

moreal commented 3 years ago

Can i work on this issue @moreal

Hello, @dineshkumar12004. Yes, you can work on this issue 😉 I assigned you on this issue.

dineshkumar12004 commented 3 years ago

hey since this is a simple typo fix should i need to run test or simple pr submission will work ?

Edit: Made a PR ;)