search

planetarium / libplanet

Blockchain in C#/.NET for on-chain, decentralized gaming
https://docs.libplanet.io/
GNU Lesser General Public License v2.1
506 stars 141 forks source link

Use another RocksDBSharp fork? #1848

Closed dahlia closed 10 months ago

dahlia commented 2 years ago

Currently the Libplanet.RocksDBStore project depends on RocksDBSharp (repo), but as its upstream has been inactive since 2019, we've had to maintain our own fork, Planetarium.RocksDBSharp (repo). However, our fork is also barely maintained, and it even bundles RocksDB binaries of v6.6, which is way behind.[^1]

Fortunately, there is another fork named RocksDB (that's a NuGet name; repo), which is actively maintained by @curiosity-ai. They has twice the commits of the original repo, and their latest commit was made just several hours ago (as of 2022-03-11). They're more promising and rather the upstream.

However, before switching over to their fork, we need to send our downstream patches to them first:

Also, they don't bundle native binaries for linux-arm64 and osx-arm64. (They appear to have willing to support the latter though. See also: https://github.com/curiosity-ai/rocksdb-sharp/issues/15.)

[^1]: Note that RocksDB 6.6 was released in 2019. Its latest version as of 2022-03-11 is v6.29.

dahlia commented 2 years ago

On bundling native libraries for linux- and osx-arm64 to @curiosity-ai's fork:

theolivenbaum commented 2 years ago

Hi there again! I'll check the two PRs later today and get them merged on our fork!

Akamig commented 2 years ago

@theolivenbaum Hi, I'm going to merge these two repositories with yours from today.

dahlia commented 1 year ago

On bundling native libraries for linux- and osx-arm64 to @curiosity-ai's fork:

Now, they finally bundle librocksdb for linux-arm64 & osx-arm64: https://github.com/curiosity-ai/rocksdb-sharp/tree/e5f98747b139d9f8d0e55c01e9ad3a7c8f92f100/csharp/runtimes.

theolivenbaum commented 1 year ago

We've released it already for osx-arm64, but if you manage to test it for linux-arm64, would be great to find out if it works!

riemannulus commented 10 months ago

At #3487, We finally tried to change our RocksDb backend.

riemannulus commented 10 months ago

https://github.com/planetarium/libplanet/pull/3487 Done