search

planetarium / libplanet

Blockchain in C#/.NET for on-chain, decentralized gaming
https://docs.libplanet.io/
GNU Lesser General Public License v2.1
506 stars 142 forks source link

Fix SwarmBenchmark IndexOutOfRangeException Error #1965

Closed Atralupus closed 1 year ago

Atralupus commented 2 years ago

Detail log: https://github.com/planetarium/libplanet/runs/5986779803?check_suite_focus=true

스크린샷 2022-05-16 오후 1 47 23

seems to be a problem here

// Libplanet.Tests/TestUtils.cs 39 line
public static readonly PrivateKey[] AdjacentKeys = new PrivateKey[10]
kasumielf commented 2 years ago

I was discover this bug not a caused by PrivateKey Array. When I attach to debug, IndexOutOfRangeException was excepted from https://github.com/planetarium/libplanet/blob/e19221ab6e59f07684c58b1f68f6ea8247a61f48/Libplanet.Benchmarks/SwarmBenchmark.cs#L62.

I'd fix this issue but not a make PR yet because SwarmBenchmark takes too much running times(over 10~15 minutes.) when I ran it.

I'm not sure this situation is not a specific. If it have no problem, I'll make PR.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.