search

planetarium / libplanet

Blockchain in C#/.NET for on-chain, decentralized gaming
https://docs.libplanet.io/
GNU Lesser General Public License v2.1
506 stars 142 forks source link

Make the KeyStore configurable in CoconaCommands #1973

Closed ipdae closed 1 year ago

ipdae commented 2 years ago

I found this issue while progressing on https://github.com/planetarium/NineChronicles.Headless/pull/1272. In NinceChronicles.Headless uses the Libplanet.Extensions.Cocona.commands wrapped once & use it because without need a dependency from the user's point of view. However, there is an inconvenience of copying and using the same code in headless. because, Libplanet commands always set the KeyStore to Web3.DefaultStore but headless commands can configure KeyStore. If the Libplanet commands changes the KeyStore to be configurable, it seems to be possible to use it immediately without copying unnecessary code.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.