Cleanup unused variables and members

[longfin]

$ dotnet tool install -g JetBrains.ReSharper.GlobalTools
$ jb inspectcode Libplanet.sln -s=WARNING -o="output"
$ cat output | grep "Unused"
    <IssueType Id="UnusedAutoPropertyAccessor.Global" Category="Potential Code Quality Issues" CategoryId="CodeSmell" SubCategory="Auto-property accessor is never used" Description="Auto-property accessor is never used: Non-private accessibility" Severity="WARNING" Global="True" />
    <IssueType Id="UnusedMember.Local" Category="Redundancies in Symbol Declarations" CategoryId="DeclarationRedundancy" SubCategory="Type member is never used" Description="Type member is never used: Private accessibility" Severity="WARNING" WikiUrl="https://www.jetbrains.com/resharperplatform/help?Keyword=UnusedMember.Local" />
    <IssueType Id="UnusedParameter.Local" Category="Redundancies in Symbol Declarations" CategoryId="DeclarationRedundancy" SubCategory="Unused parameter" Description="Unused parameter: Private accessibility" Severity="WARNING" />
    <IssueType Id="UnusedVariable" Category="Redundancies in Symbol Declarations" CategoryId="DeclarationRedundancy" Description="Unused local variable" Severity="WARNING" WikiUrl="https://www.jetbrains.com/resharperplatform/help?Keyword=UnusedVariable" />
      <Issue TypeId="UnusedVariable" File="Libplanet\Action\PolymorphicAction.cs" Offset="10850-10853" Line="269" Message="Local variable 'asm' is never used" />
      <Issue TypeId="UnusedVariable" File="Libplanet\Blockchain\BlockChain.MineBlock.cs" Offset="14244-14248" Line="302" Message="Local variable 'tpve' is never used" />
      <Issue TypeId="UnusedVariable" File="Libplanet\Blockchain\BlockChain.Swap.cs" Offset="2932-2937" Line="82" Message="Local variable 'reorg' is never used" />
      <Issue TypeId="UnusedAutoPropertyAccessor.Global" File="Libplanet\Blockchain\IncompleteBlockStatesException.cs" Offset="1365-1369" Line="36" Message="Auto-property accessor 'BlockHash.get' is never used" />
      <Issue TypeId="UnusedAutoPropertyAccessor.Global" File="Libplanet\Blockchain\MineBlockEventArgs.cs" Offset="308-312" Line="15" Message="Auto-property accessor 'Block.get' is never used" />
      <Issue TypeId="UnusedAutoPropertyAccessor.Global" File="Libplanet\Blockchain\Renderers\DelayedRenderer.cs" Offset="4778-4782" Line="101" Message="Auto-property accessor 'CanonicalChainComparer.get' is never used" />
      <Issue TypeId="UnusedAutoPropertyAccessor.Global" File="Libplanet\Blocks\InvalidGenesisBlockException.cs" Offset="1526-1530" Line="39" Message="Auto-property accessor 'NetworkExpected.get' is never used" />
      <Issue TypeId="UnusedAutoPropertyAccessor.Global" File="Libplanet\Blocks\InvalidGenesisBlockException.cs" Offset="1702-1706" Line="45" Message="Auto-property accessor 'Stored.get' is never used" />
      <Issue TypeId="UnusedAutoPropertyAccessor.Global" File="Libplanet\KeyStore\NoKeyException.cs" Offset="1003-1007" Line="29" Message="Auto-property accessor 'KeyId.get' is never used" />
      <Issue TypeId="UnusedMember.Local" File="Libplanet\Store\DefaultStore.cs" Offset="3727-3747" Line="90" Message="Constant 'TxIdBlockIndexPrefix' is never used" />
      <Issue TypeId="UnusedMember.Local" File="Libplanet\Store\DefaultStore.cs" Offset="25693-25699" Line="691" Message="Method 'Loader' is never used" />
      <Issue TypeId="UnusedMember.Local" File="Libplanet\Store\DefaultStore.cs" Offset="29991-29993" Line="813" Message="Property 'Id' is never used" />
      <Issue TypeId="UnusedMember.Local" File="Libplanet\Store\MemoryStore.cs" Offset="10702-10708" Line="285" Message="Method 'Loader' is never used" />
      <Issue TypeId="UnusedMember.Local" File="Libplanet\Tx\Transaction.cs" Offset="1155-1170" Line="32" Message="Constant 'TimestampFormat' is never used" />
      <Issue TypeId="UnusedParameter.Local" File="Libplanet\Tx\Transaction.cs" Offset="7600-7606" Line="137" Message="Parameter 'signer' is never used" />
      <Issue TypeId="UnusedMember.Local" File="Libplanet\Tx\Transaction.cs" Offset="11619-11622" Line="240" Message="Accessor 'Signature.set' is never used" />
      <Issue TypeId="UnusedParameter.Local" File="Libplanet\Tx\TxExecution.cs" Offset="827-834" Line="21" Message="Parameter 'context' is never used" />

(Thanks ReSharper CLI 😄 )

[sigridjineth]

I would assume the issue this :) #HacktoberFest

[sigridjineth]

would better to install the JB tools by specifying the version like the below

dotnet tool install --global JetBrains.ReSharper.GlobalTools --version 2022.2.3

FYI for the path verification (on my machine for ex)

export PATH="$PATH:/Users/sigridjin.eth/.dotnet/tools"

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.