Refactor `GetBlockCommit()`

planetarium / libplanet

Blockchain in C#/.NET for on-chain, decentralized gaming

https://docs.libplanet.io/

GNU Lesser General Public License v2.1

516 stars 145 forks source link

Closed greymistcube closed 2 years ago

greymistcube commented 2 years ago

I think GetBlockCommit(long index) should work as the following:

Retrieve the Block<T> of given index.
If the retrieved Block<T> is a PoW block, return null.
If the retrieved Block<T> is a PBFT block:
- If index == Tip.Index, then return the BlockCommit cached.
- If index < Tip.Index, then return the Block<T>.LastCommit of the next block.

colibrishin commented 2 years ago

I'll take this for focusing and continuing the GetBlockCommit() work context.

colibrishin commented 2 years ago

Closed by #2553