@planetarium/cli fails to install with recent Node.js versions on Windows

planetarium / libplanet

Blockchain in C#/.NET for on-chain, decentralized gaming

https://docs.libplanet.io/

GNU Lesser General Public License v2.1

511 stars 144 forks source link

@planetarium/cli fails to install with recent Node.js versions on Windows #3107

Closed OnedgeLee closed 1 year ago

OnedgeLee commented 1 year ago

After upgrading Bencodex 0.9.0 to Bencodex 0.10.0, CI @planetarium/cli installation test (windows-latest) fails.

Changes on Bencodex 0.10.0

Bencodex.Types.IndirectValue.GetHashCode() now returns hash code of its Fingerprint.
- https://github.com/planetarium/bencodex.net/pull/79

greymistcube commented 1 year ago

May or may not be related, but seems like there was a runner image update recently with a version bump in PowerShell. 😗

dahlia commented 1 year ago

Turns out it is not related to PowerShell, but is due to node-unzipper's bug (https://github.com/ZJONSSON/node-unzipper/issues/271) on recent Node.js versions. I'm going to replace it with extract-zip which apparently works well regardless of Node.js versions.