planetarium / libplanet

Blockchain in C#/.NET for on-chain, decentralized gaming
https://docs.libplanet.io/
GNU Lesser General Public License v2.1
506 stars 139 forks source link

💔 Report problem of Libplanet.Explorer GraphQL schema changes #3656

Closed riemannulus closed 4 months ago

riemannulus commented 5 months ago

Context

Since https://github.com/planetarium/libplanet/releases/tag/3.9.3 and https://github.com/planetarium/libplanet/releases/tag/3.9.4, Libplanet.Explorer schema is changed. But it causes problems for other external services that use the Libplanet.Explorer query type.

Please report to comment with problem details and repository URLs.

U-lis commented 5 months ago

When using TransactionResult query, the response type has been changed from TxResultType to TxResult. This causes IAP and SeasonPass service to not to fetch transaction result and update to DB.

greymistcube commented 5 months ago

@U-lis Can it be resolved by changing TxResultType to TxResult? It was a mistake to not have a name for the type defined and use auto generated name TxResultType in the first place (all other types already had names defined). The overall schema needs to be updated due to additional types being defined and/or being changed (like BlockHash no longer being an ID but its own type, etc.)

U-lis commented 5 months ago

@U-lis Can it be resolved by changing TxResultType to TxResult? It was a mistake to not have a name for the type defined and use auto generated name TxResultType in the first place (all other types already had names defined). The overall schema needs to be updated due to additional types being defined and/or being changed (like BlockHash no longer being an ID but its own type, etc.)

Yes, this issue can be resolved by changing TxResultType to TxResult in query. Then I'll update type name to newer one.

greymistcube commented 5 months ago

@U-lis Since there are too many changes to account for, we'll try to roll back changes and release 4.0.3.

riemannulus commented 4 months ago

Rollback all schema. closed this issues