Closed OnedgeLee closed 4 months ago
This PR has 50
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 46
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
Newly fixed test seems to only test FAV changed during fee processing. I think we should also test an IAction
that uses gas and makes changes to FAV. 😶
@greymistcube
Newly fixed test seems to only test FAV changed during fee processing. I think we should also test an
IAction
that uses gas and makes changes to FAV. 😶
On L1032
, checking if TotalUpdatedFungibleAssets
of Gas
is equal to total count of transactions. I thought this test is for TotalUpdatedFungibleAssets
, and it's enough.
For Gas processing, it seems other tests are covering.
IMO this PR needs to log into changelog. Because this is fix a bug, not a chore thing.
This PR has 49
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 49
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 50
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 50
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
TotalUpdatedFungibleAssets
has been omitted since replacement ofAccount
has been happend onMortgage
. This makesTotalUpdatedFungibleAssets
of transactions untractable, except last transaction of block.This was an unintended error, so fix on this PR.