Closed s2quake closed 4 months ago
This PR has 115
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 118
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
Eh, I think implementing IDictionary<K, V>
is still an overkill since BlockSet
is supposed to be readonly really.
How about changing it to IReadOnlydictionary<K, V>
?
This PR has 118
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 118
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 119
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 121
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
Eh, I think implementing
IDictionary<K, V>
is still an overkill sinceBlockSet
is supposed to be readonly really. How about changing it toIReadOnlydictionary<K, V>
?
The _blocks
field in BlockChain
has a write operation code, so I changed its type to BlockSet
.
see this
I guess I missed it somehow. Very well, I still think there are larger design issues pertaining to this problem, such as its scope and features, but I think this is enough for now.
https://github.com/planetarium/libplanet/issues/3645