Closed greymistcube closed 6 months ago
This PR has 87
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 90
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
@riemannulus Can it be considered a behavioral change if it wasn't there in the first place? 🤔 The description of the property explains what it's supposed to do, but I don't think of it as being changed.
The description of the property explains what it's supposed to do, but I don't think of it as being changed.
Fair enough.
In preparation to remove
TotalUpdatedFungibleAssets
fromIWorld
. Having volatile non-state dependency in two different places, namelyIActionContext
andIWorld
, is causing too much trouble. 🙄Also since
ActionEvaluator
is doing more and more heavy lifting in terms of context management, I've widened the scope from which its evaluating methods can pull necessary context from (it was also to avoid adding an additional parameter to numerous methods). This might come in handy later when we introduce evidences. 😗