Closed greymistcube closed 3 months ago
This PR has 62
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 70
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 70
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 70
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 70
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
Benchmark failed 😢
@riemannulus Some performance change is to be expected since there was a security patch. I'd say patching the security hole takes precedence over performance. 🙄
⬆️ Older versions have a known critical security vulnerability. See Here.
I haven't thoroughly gone through the changes, but the following options have been removed:
journal
: Seems like this option has been entirely removed by LiteDB. I presume this is controlled automatically depending on the type of disk used.indexCahceSize
: This has been changed to a constant in LiteDB with no control possible on our end.flush
: Seems like the option has been taken away in LiteDB and always flushes to disk when a disk is being used.PS. Newer versions such as 5.0.17 and 5.0.19 doesn't work properly for some reason and I have failed to resolve the issue. 😥