Remove Sonar Analyzer suppressions

planetarium / libplanet

Blockchain in C#/.NET for on-chain, decentralized gaming

https://docs.libplanet.io/

GNU Lesser General Public License v2.1

506 stars 139 forks source link

Open earlbread opened 4 years ago

earlbread commented 4 years ago

We need to remove Sonar Analyzer suppressions.

[x] S927: Rename parameter 'A' to 'B' to match the interface declaration.
[x] S1066: Merge this if statement with the enclosing one.
[x] S1118: Add a 'protected' constructor or the 'static' keyword to the class declaration.
[x] S1125: Remove the unnecessary Boolean literal(s).
[x] S1450: Remove the field '_bucketSize' and declare it as a local variable in the relevant methods.
[ ] S1481: Remove the unused local variable 'x'.
[x] S2234: Parameters to 'Equal' have the same names but not the same order as the method arguments.
[x] S3358: Extract this nested ternary operation into an independent statement.
[x] S3442: Change the visibility of this constructor to 'protected'.
[x] S4035: Seal class or implement 'IEqualityComparer' instead.
[x] S4201: Remove this unnecessary null check; 'is' returns false for nulls.

hmc0105 commented 4 years ago

I want to do deleting suppression S927

dahlia commented 4 years ago

We suppressed S1128 warnings too here and there in order to work around the bug https://github.com/SonarSource/sonar-dotnet/issues/2694, but now it seems fixed (https://github.com/SonarSource/sonar-dotnet/pull/2798). So we should restore these suppressed warnings now.

Oaroomy commented 4 years ago

I'm going to work on S1066

Oaroomy commented 4 years ago

I'm going to work on S1118

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stylesm commented 3 years ago

I'm going to work on the remaining surpressions here.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

OnedgeLee commented 1 year ago

~~Seems to have been resolved already.~~ ~~All checklists are marked except S1481, and when I opened Libplanet.ruleset, could find lines below.~~

    <!-- Remove the unused local variable 'x'. -->
    <Rule Id="S1481" Action="None" />

Misunderstood the issue target

sindydwns commented 1 year ago

✋

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.