Closed sentry-io[bot] closed 1 year ago
Sentry issue: 9C-STANDALONE-RB
Because the Connected property only reflects the state of the connection as of the most recent operation, you should attempt to send or receive a message to determine the current state. After the message send fails, this property no longer returns true. Note that this behavior is by design. You cannot reliably test the state of the connection because, in the time between the test and a send/receive, the connection could have been lost. Your code should assume the socket is connected, and gracefully handle failed transmissions.
We may rethink the handling of connection stabilization with TurnClient.EnsureConnection()
. 😕
Continued from https://github.com/planetarium/libplanet/pull/972#issuecomment-682069085
It would be better if we moved TURN related tasks(e.g. RefreshAllocation
) from NetMQTransport
to TurnClient
because we can organize re-connecting codes into only TurnClient
, not NetMQTransport
.
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.
Sentry Issue: 9C-STANDALONE-PP