search

planetarium / mimir

A backend service that provides 9c-related utility APIs.
https://nine-chronicles.dev/
GNU Affero General Public License v3.0
1 stars 5 forks source link

Fix typo #341

Closed moreal closed 2 days ago

moreal commented 1 week ago

https://github.com/planetarium/mimir/blob/4882bec83747db9a85544fa3e668a2db1bf4fc95/Mimir.Worker/Poller/DiffPoller/DiffConsumer.cs#L110

DiffCOunt should be DiffCount.

TheMarvelFan commented 1 week ago

Hi, is anyone working on this issue? If not, I would like to take it up.

Atralupus commented 1 week ago

Hi, is anyone working on this issue? If not, I would like to take it up.

Of course!

TheMarvelFan commented 6 days ago

Hi @Atralupus,

I have created a PR for fixing this issue. Please review it and let me know if any changes are required.

Thanks!

moreal commented 6 days ago

Hi @TheMarvelFan, thanks for your contribution!! 🎉

I have a question about your Hacktoberfest participant.

Copied from https://hacktoberfest.com/participation/

Aim to submit four high-quality pull/merge requests between October 1 and October 31, with project maintainers accepting your pull/merge requests for them to count toward your total

According to the Hacktoberfest site, if you want to stack Hacktoberfest pull request count, it may need to be merged after October 1. Should I merge in October?

TheMarvelFan commented 6 days ago

Thanks for asking @moreal!

It would be really helpful if you can do that. I am currently working on another issue in this repo, and I would really appreciate it if you can merge that PR in October as well.

Thanks!

moreal commented 6 days ago

Okay I'll do, thank you!

TheMarvelFan commented 3 days ago

Hi @moreal ,

It looks like I will have to recreate the PR. The following is from the Hacktoberfest website:

Pull/merge requests created before October 1 but merged or marked as ready for review after do not count.

TheMarvelFan commented 2 days ago

@moreal @Atralupus I have recreated the PR for this issue, and it is now able to be marged under Hacktoberfest.