search

planetarium / planet-node

A simple node implementation using Libplanet
GNU Affero General Public License v3.0
7 stars 13 forks source link

Fix warnings on `dotnet build` #21

Closed longfin closed 1 year ago

longfin commented 2 years ago 
[longfin@longfin-desktop-arch planet-node]$ git rev-parse HEAD
5c607b4e91eb14f12c8fdd085ac1f20807e3b819

[longfin@longfin-desktop-arch planet-node]$ dotnet build
Microsoft (R) Build Engine version 17.0.0+c9eb9dd64 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  Libplanet.Stun -> /home/longfin/planet-node/libplanet/Libplanet.Stun/bin/Debug/netcoreapp3.1/Libplanet.Stun.dll
  Libplanet -> /home/longfin/planet-node/libplanet/Libplanet/bin/Debug/netcoreapp3.1/Libplanet.dll
  Libplanet.Net -> /home/longfin/planet-node/libplanet/Libplanet.Net/bin/Debug/netcoreapp3.1/Libplanet.Net.dll
  Libplanet -> /home/longfin/planet-node/libplanet/Libplanet/bin/Debug/netstandard2.0/Libplanet.dll
  Libplanet.RocksDBStore -> /home/longfin/planet-node/libplanet/Libplanet.RocksDBStore/bin/Debug/netstandard2.0/Libplanet.RocksDBStore.dll
  Successfully created package '/home/longfin/planet-node/libplanet/Libplanet.RocksDBStore/bin/Debug/Libplanet.RocksDBStore.1.0.0.nupkg'.
  Libplanet.Headless -> /home/longfin/planet-node/Libplanet.Headless/bin/Debug/net6.0/Libplanet.Headless.dll
  Libplanet.Stun -> /home/longfin/planet-node/libplanet/Libplanet.Stun/bin/Debug/netstandard2.0/Libplanet.Stun.dll
  Libplanet.Explorer -> /home/longfin/planet-node/libplanet/Libplanet.Explorer/bin/Debug/net6.0/Libplanet.Explorer.dll
  Successfully created package '/home/longfin/planet-node/libplanet/Libplanet.Explorer/bin/Debug/Libplanet.Explorer.1.0.0.nupkg'.
  Libplanet.Net -> /home/longfin/planet-node/libplanet/Libplanet.Net/bin/Debug/netstandard2.0/Libplanet.Net.dll
  Libplanet.Extensions.Cocona -> /home/longfin/planet-node/libplanet/Libplanet.Extensions.Cocona/bin/Debug/netstandard2.0/Libplanet.Extensions.Cocona.dll
  Successfully created package '/home/longfin/planet-node/libplanet/Libplanet.Extensions.Cocona/bin/Debug/Libplanet.Extensions.Cocona.1.0.0.nupkg'.
/home/longfin/planet-node/PlanetNode/ExplorerContextBuilder.cs(16,9): warning CS8619: Nullability of reference types in value of type 'Task<IDictionary<string, object?>>' doesn't match target type 'Task<IDictionary<string, object>>'. [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/ExplorerContextBuilder.cs(7,16): warning S3903: Move 'ExplorerContextBuilder' into a named namespace. [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/InvalidTransferSignerException.cs(9,16): warning S3871: Make this exception 'public'. [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/InvalidTransferSignerException.cs(4,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/PlanetAction.cs(11,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/ExplorerContextBuilder.cs(15,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/ExplorerContext.cs(13,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/TransferAsset.cs(26,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/TransferAsset.cs(27,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(1,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(3,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(4,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(8,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(14,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(16,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(18,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/ExplorerContextBuilder.cs(14,6): warning SA1513: Closing brace should be followed by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/GraphTypes/PlanetNodeQuery.cs(17,9): warning SA1515: Single-line comment should be preceded by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(72,6): warning SA1513: Closing brace should be followed by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(37,17): warning SA1413: Use trailing comma in multi-line initializers [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
  PlanetNode -> /home/longfin/planet-node/PlanetNode/bin/Debug/net6.0/PlanetNode.dll

Build succeeded.

/home/longfin/planet-node/PlanetNode/ExplorerContextBuilder.cs(16,9): warning CS8619: Nullability of reference types in value of type 'Task<IDictionary<string, object?>>' doesn't match target type 'Task<IDictionary<string, object>>'. [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/ExplorerContextBuilder.cs(7,16): warning S3903: Move 'ExplorerContextBuilder' into a named namespace. [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/InvalidTransferSignerException.cs(9,16): warning S3871: Make this exception 'public'. [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/InvalidTransferSignerException.cs(4,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/PlanetAction.cs(11,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/ExplorerContextBuilder.cs(15,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/ExplorerContext.cs(13,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/TransferAsset.cs(26,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Action/TransferAsset.cs(27,1): warning SA1516: Elements should be separated by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(1,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(3,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(4,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(8,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(14,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(16,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(18,1): warning SA1210: Using directives should be ordered alphabetically by the namespaces [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/ExplorerContextBuilder.cs(14,6): warning SA1513: Closing brace should be followed by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/GraphTypes/PlanetNodeQuery.cs(17,9): warning SA1515: Single-line comment should be preceded by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(72,6): warning SA1513: Closing brace should be followed by blank line [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
/home/longfin/planet-node/PlanetNode/Program.cs(37,17): warning SA1413: Use trailing comma in multi-line initializers [/home/longfin/planet-node/PlanetNode/PlanetNode.csproj]
    20 Warning(s)
    0 Error(s)

Currently(5c607b4e91eb14f12c8fdd085ac1f20807e3b819), there are some warnings and they seem lint errors.😅

2uijin commented 2 years ago

(❁´◡`❁)