search

planetarium / pnscan-cloud

Nine Chronicles Blockchain Explorer Backend Project. Apache2.0
Apache License 2.0
1 stars 0 forks source link

Adjust query for txResult #4

Closed longfin closed 2 years ago

longfin commented 2 years ago

This PR modifies a query for transactionResult to adopt suggested format to Libplanet.Explorer. (see also https://github.com/planetarium/libplanet/pull/2130)

kimwz commented 2 years ago

You may need to check the return value.

return data['data']['transaction']['transactionResult']['txStatus']
pull-request-quantifier-deprecated[bot] commented 2 years ago

This PR has 18 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

``` Label : Extra Small Size : +10 -8 Percentile : 7.2% Total files changed: 2 Change summary by file extension: .js : +10 -8 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detetcted. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.

Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

longfin commented 2 years ago

You may need to check the return value.

return data['data']['transaction']['transactionResult']['txStatus']

Amended. (https://github.com/planetarium/pnscan-cloud/pull/4/commits/a625c94e71f4bc53a54602376bc26d5a04e0dd64)

@kimwz Thanks for pointing out, PTAL 🙏