planetarium / snack.planetarium.dev

Planetarium Engineering Snack
https://snack.planetarium.dev/
9 stars 15 forks source link

페타바이트 트래픽 원인 분석기 #155

Closed moreal closed 1 year ago

moreal commented 1 year ago

2022년 4월 즈음 발견했던, 그리고 지금도 유효한 CloudWatch Agent의 버그를 조사했던 이야기를 스낵글로 적어봤습니다. 하단 링크에서 읽어보실 수 있습니다.

https://deploy-preview-155--planetarium-engineering-snack.netlify.app/kor/2023/03/cloudwatch/

netlify[bot] commented 1 year ago

Deploy Preview for planetarium-engineering-snack ready!

Name Link
Latest commit 81f5cec36a89d43ffe5729e0b4e3c7bafca548f1
Latest deploy log https://app.netlify.com/sites/planetarium-engineering-snack/deploys/641c1a285f47c700084f0bb1
Deploy Preview https://deploy-preview-155--planetarium-engineering-snack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

moreal commented 1 year ago

코드 부분에 정리되지 않은 오타가 있어서 지워서 다시 푸시했습니다

pull-request-quantifier-deprecated[bot] commented 1 year ago

This PR has 61 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

``` Label : Small Size : +61 -0 Percentile : 24.4% Total files changed: 1 Change summary by file extension: .md : +61 -0 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detected. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.


Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.